RPM Community Forums

Mailing List Message of <rpm-devel>

Re: %patch fully broken

From: Jeff Johnson <n3npq@mac.com>
Date: Mon 23 Jul 2007 - 17:30:03 CEST
Message-Id: <641C3A66-F61E-49E1-B33E-2ED7E651965B@mac.com>

On Jul 23, 2007, at 10:45 AM, Hatle, Mark wrote:

>
> Something must have changed since 0714.  Thats the date of RPM I'm  
> using and all of my checkins are current AFAIK.
>

Several things changed. %patch is likely to work as before when  
rolled back in. The change
in 3 parts needs coordinated.

Also the fix for
    #%patchNN
commemnting needs revisiting, because it exposes %{_P} et al outside  
of the context in which it is used.

I'd rather add a "#%" macro primitive, or not expand comments, rather  
than hack around with
parameterized macro internals. There are reasons noty to populate  
everything in the
global macro name space.
> It's working properly for me including the %patch001 translates to % 
> patch1.
>
> Attempting to call %patch on the --eval line will fail, because the  
> macro parser and the macro itself will attempt to use %PATCH0,  
> which isn't defined in an eval, you need to be in a specfile for  
> that to be defined.
>
> I've built somewhere around 400 source packages (of varying  
> quality) and had no further problem.. (most are Fedora based.)
>

Good.

73 de Jeff
>
>
Received on Mon Jul 23 17:30:20 2007
Driven by Jeff Johnson and the RPM project team.
Hosted by OpenPKG and Ralf S. Engelschall.
Powered by FreeBSD and OpenPKG.